This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: add --hidden flag to cli add command#2649
Merged
achingbrain merged 3 commits intomasterfrom Dec 10, 2019
Merged
Conversation
Member
|
Can you fix up the tests please? |
PedroMiguelSS
force-pushed
the
feat/cli-hidden-flag-add-command
branch
5 times, most recently
from
e4f5717 to
4683ba1
Compare
hugomrdias
approved these changes
Dec 6, 2019
Member
hugomrdias
left a comment
hugomrdias
left a comment
There was a problem hiding this comment.
Please remove the console.log and skip the unrelated examples tests.
@achingbrain are you aware of whats going on with these tests ?
PedroMiguelSS
force-pushed
the
feat/cli-hidden-flag-add-command
branch
from
4683ba1 to
449bb01
Compare
Member
|
@hugomrdias the broken examples tests will be fixed by jkroso/parse-duration#11 |
Contributor
Author
|
jkroso/parse-duration#11 fixed the problem. CI is fully green now 🎉 |
achingbrain
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--hiddenflag to CLI'saddcommand.Closes #1917.